Skip to content

[feat](fe) add recovery_journal_id to truncate bdbje logs#60738

Open
w41ter wants to merge 3 commits intoapache:masterfrom
w41ter:feat/truncate_bdbje_logs
Open

[feat](fe) add recovery_journal_id to truncate bdbje logs#60738
w41ter wants to merge 3 commits intoapache:masterfrom
w41ter:feat/truncate_bdbje_logs

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Feb 13, 2026

It only works for metadata_failure_recovery mode

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

It only works for metadata_failure_recovery mode
@w41ter w41ter added the cloud label Feb 13, 2026
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Feb 13, 2026

run buildall

gavinchou
gavinchou previously approved these changes Feb 13, 2026
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 13, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

mymeiyi
mymeiyi previously approved these changes Feb 13, 2026
@doris-robot
Copy link

TPC-H: Total hot run time: 28982 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6fdca7b55774a088d08a5fdd2652b2d5a8de4c6a, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17596	4555	4321	4321
q2	q3	10650	839	541	541
q4	4685	349	261	261
q5	7567	1207	1036	1036
q6	178	181	153	153
q7	786	854	678	678
q8	9454	1475	1324	1324
q9	4951	4763	4756	4756
q10	6864	1880	1636	1636
q11	478	262	243	243
q12	754	563	473	473
q13	17776	4217	3436	3436
q14	228	229	215	215
q15	989	802	790	790
q16	755	724	675	675
q17	734	853	443	443
q18	5988	5354	5302	5302
q19	1540	988	644	644
q20	527	492	384	384
q21	4682	1838	1424	1424
q22	346	288	247	247
Total cold run time: 97528 ms
Total hot run time: 28982 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4512	4360	4383	4360
q2	q3	1762	2184	1733	1733
q4	851	1176	780	780
q5	4070	4348	4283	4283
q6	178	175	146	146
q7	1729	1568	1477	1477
q8	2425	2694	2511	2511
q9	7558	7426	7502	7426
q10	2739	2878	2528	2528
q11	538	463	428	428
q12	504	594	452	452
q13	3959	4413	3648	3648
q14	301	305	280	280
q15	877	912	839	839
q16	736	752	734	734
q17	1147	1639	1389	1389
q18	7146	6799	6697	6697
q19	879	867	878	867
q20	2121	2214	1997	1997
q21	4239	3479	3406	3406
q22	501	482	427	427
Total cold run time: 48772 ms
Total hot run time: 46408 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185005 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6fdca7b55774a088d08a5fdd2652b2d5a8de4c6a, data reload: false

query5	4704	650	518	518
query6	333	234	211	211
query7	4216	477	285	285
query8	377	250	239	239
query9	8689	2763	2818	2763
query10	519	405	345	345
query11	17155	17713	17558	17558
query12	194	144	137	137
query13	1353	466	347	347
query14	6862	3398	3056	3056
query14_1	2881	2951	2853	2853
query15	220	207	180	180
query16	988	488	473	473
query17	1452	723	658	658
query18	2833	451	373	373
query19	212	219	204	204
query20	134	129	122	122
query21	233	165	139	139
query22	5392	4998	4733	4733
query23	17275	16909	16705	16705
query23_1	16809	16801	16740	16740
query24	7207	1640	1236	1236
query24_1	1258	1241	1237	1237
query25	574	483	423	423
query26	1233	264	153	153
query27	2777	484	293	293
query28	4479	1881	1885	1881
query29	811	613	489	489
query30	328	251	210	210
query31	904	726	653	653
query32	79	75	74	74
query33	545	362	292	292
query34	934	930	566	566
query35	632	690	608	608
query36	1068	1086	961	961
query37	148	103	87	87
query38	2980	2937	2870	2870
query39	864	847	814	814
query39_1	816	804	804	804
query40	237	159	144	144
query41	72	68	64	64
query42	109	109	104	104
query43	372	388	357	357
query44	
query45	209	188	186	186
query46	885	992	611	611
query47	2144	2147	2067	2067
query48	318	342	239	239
query49	640	486	403	403
query50	686	295	219	219
query51	4126	4156	4055	4055
query52	110	110	97	97
query53	301	342	289	289
query54	317	282	281	281
query55	94	90	83	83
query56	314	363	299	299
query57	1367	1331	1289	1289
query58	280	277	269	269
query59	2549	2653	2510	2510
query60	330	342	326	326
query61	151	147	149	147
query62	628	587	563	563
query63	314	286	280	280
query64	4844	1279	981	981
query65	
query66	1418	454	343	343
query67	16498	16596	16426	16426
query68	
query69	397	302	278	278
query70	992	983	943	943
query71	351	309	309	309
query72	2897	2661	2550	2550
query73	540	550	330	330
query74	9581	9578	9336	9336
query75	2809	2747	2457	2457
query76	2292	1030	697	697
query77	384	384	313	313
query78	11600	11817	11072	11072
query79	2475	800	615	615
query80	1790	618	543	543
query81	560	287	252	252
query82	998	148	114	114
query83	326	253	264	253
query84	253	128	102	102
query85	891	486	440	440
query86	405	309	292	292
query87	3103	3093	2954	2954
query88	3562	2696	2700	2696
query89	425	383	348	348
query90	1986	179	183	179
query91	169	155	131	131
query92	84	79	66	66
query93	1134	835	514	514
query94	641	323	304	304
query95	587	337	318	318
query96	638	513	228	228
query97	2466	2507	2424	2424
query98	238	225	212	212
query99	1034	987	903	903
Total cold run time: 257193 ms
Total hot run time: 185005 ms

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 26.73% (27/101) 🎉
Increment coverage report
Complete coverage report

@w41ter w41ter dismissed stale reviews from mymeiyi and gavinchou via 5209621 February 13, 2026 08:58
@w41ter
Copy link
Contributor Author

w41ter commented Feb 13, 2026

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 13, 2026
@w41ter
Copy link
Contributor Author

w41ter commented Feb 13, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 29060 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c5eb0a4a328f70e2cb516b4cada457ee80e5d8f, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17653	4452	4318	4318
q2	q3	10652	771	523	523
q4	4679	358	257	257
q5	7564	1204	1006	1006
q6	171	175	149	149
q7	766	851	660	660
q8	9289	1470	1380	1380
q9	4780	4707	4734	4707
q10	6775	1873	1639	1639
q11	463	250	261	250
q12	726	567	469	469
q13	17765	4205	3396	3396
q14	228	238	213	213
q15	923	804	821	804
q16	704	727	680	680
q17	696	844	443	443
q18	5925	5378	5316	5316
q19	1105	982	631	631
q20	507	482	392	392
q21	4664	1970	1567	1567
q22	383	311	260	260
Total cold run time: 96418 ms
Total hot run time: 29060 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4782	4530	4490	4490
q2	q3	1790	2197	1736	1736
q4	895	1206	783	783
q5	4020	4399	4305	4305
q6	182	177	156	156
q7	1785	1639	1521	1521
q8	2481	2852	2562	2562
q9	7405	7468	7226	7226
q10	2699	2792	2431	2431
q11	515	456	420	420
q12	519	583	459	459
q13	4049	4429	3558	3558
q14	278	383	402	383
q15	941	835	805	805
q16	713	756	706	706
q17	1159	1476	1298	1298
q18	7037	6698	6676	6676
q19	922	908	917	908
q20	2278	2164	2047	2047
q21	4010	3544	3423	3423
q22	508	483	423	423
Total cold run time: 48968 ms
Total hot run time: 46316 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184443 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c5eb0a4a328f70e2cb516b4cada457ee80e5d8f, data reload: false

query5	5029	647	532	532
query6	353	232	212	212
query7	4228	468	273	273
query8	347	256	246	246
query9	8748	2752	2746	2746
query10	564	380	338	338
query11	17175	17585	17507	17507
query12	212	129	130	129
query13	1291	495	364	364
query14	7690	3383	3106	3106
query14_1	2938	2939	2997	2939
query15	238	200	190	190
query16	1020	490	474	474
query17	1257	767	649	649
query18	2768	448	352	352
query19	216	217	179	179
query20	138	133	130	130
query21	223	137	117	117
query22	4991	4845	4914	4845
query23	17328	16953	16697	16697
query23_1	16962	16759	16851	16759
query24	7156	1615	1227	1227
query24_1	1244	1265	1241	1241
query25	547	443	399	399
query26	1228	256	147	147
query27	2774	464	287	287
query28	4458	1877	1861	1861
query29	798	543	460	460
query30	322	246	209	209
query31	885	725	644	644
query32	79	70	76	70
query33	535	333	276	276
query34	937	922	573	573
query35	645	672	582	582
query36	1058	1114	943	943
query37	129	88	83	83
query38	2944	2898	2914	2898
query39	856	859	802	802
query39_1	791	800	853	800
query40	224	151	136	136
query41	73	60	60	60
query42	107	104	105	104
query43	396	382	362	362
query44	
query45	198	185	180	180
query46	878	977	604	604
query47	2138	2156	2092	2092
query48	306	314	223	223
query49	622	456	371	371
query50	676	281	218	218
query51	4128	4121	4139	4121
query52	104	106	96	96
query53	286	330	285	285
query54	285	277	261	261
query55	93	81	88	81
query56	301	297	308	297
query57	1382	1360	1280	1280
query58	286	281	271	271
query59	2628	2626	2527	2527
query60	327	335	307	307
query61	147	145	144	144
query62	610	589	538	538
query63	307	267	278	267
query64	4830	1273	992	992
query65	
query66	1387	449	350	350
query67	16339	16579	16289	16289
query68	
query69	406	316	289	289
query70	1025	987	908	908
query71	331	308	301	301
query72	2781	2721	2348	2348
query73	540	541	318	318
query74	9645	9558	9382	9382
query75	2842	2730	2462	2462
query76	2284	1024	666	666
query77	361	395	313	313
query78	11717	11798	11033	11033
query79	3332	858	593	593
query80	1830	614	536	536
query81	578	285	253	253
query82	999	143	114	114
query83	360	259	243	243
query84	257	119	99	99
query85	912	474	436	436
query86	407	332	296	296
query87	3077	3063	2996	2996
query88	3562	2689	2668	2668
query89	422	365	353	353
query90	1994	169	168	168
query91	166	152	133	133
query92	75	79	69	69
query93	1286	811	517	517
query94	652	318	283	283
query95	588	326	311	311
query96	639	518	234	234
query97	2454	2511	2381	2381
query98	235	214	218	214
query99	981	996	884	884
Total cold run time: 258824 ms
Total hot run time: 184443 ms

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 29.70% (30/101) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 2.97% (3/101) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants