Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jan 12, 2026

What problem does this PR solve?

This pull request addresses the handling of the set_ready() call for the RecCTESharedState in the pipeline execution logic. The main change is to ensure that the readiness signal is set at the correct point in the pipeline, specifically after the exchange source has been reset, to prevent potential deadlocks.

Key changes:

Pipeline execution logic:

  • Moved the call to set_ready() for RecCTESharedState from the RecCTESinkOperatorX to the pipeline task execution, ensuring it is invoked after the exchange source reset to avoid blocking issues. [1] [2]

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 12, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.06% (18994/35797)
Line Coverage 39.12% (176087/450065)
Region Coverage 33.70% (136356/404639)
Branch Coverage 34.72% (58943/169743)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (4/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.94% (25934/35075)
Line Coverage 61.37% (275852/449468)
Region Coverage 56.25% (230146/409140)
Branch Coverage 58.15% (99155/170504)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (4/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.93% (25931/35075)
Line Coverage 61.35% (275735/449468)
Region Coverage 56.22% (230006/409140)
Branch Coverage 58.12% (99095/170504)

hello-stephen
hello-stephen previously approved these changes Jan 13, 2026
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 13, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 13, 2026
HappenLee
HappenLee previously approved these changes Jan 13, 2026
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 13, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 13, 2026
@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 36.84% (7/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.00% (18976/35807)
Line Coverage 39.05% (175899/450429)
Region Coverage 33.63% (136160/404881)
Branch Coverage 34.66% (58873/169852)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 78.95% (15/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.31% (25372/35089)
Line Coverage 59.13% (265982/449839)
Region Coverage 53.94% (220819/409386)
Branch Coverage 55.64% (94924/170613)

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit a18d2bf into apache:master Jan 14, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. rec_cte reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants