-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](oss)Support bucket-domain-name #59755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CalvinKirs
wants to merge
3
commits into
apache:master
Choose a base branch
from
CalvinKirs:master-oss-bucket.endpoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31034 ms |
TPC-DS: Total hot run time: 172694 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
Member
Author
|
run external |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Aliyun OSS supports accessing buckets using a bucket domain name format, for example:
oss://bucket.endpoint/path
In the Hadoop ecosystem, support for this URI style differs:
JindoFS supports this format(JindoFS rewrites and extends AliyunOSSFileSystem)
It can correctly parse and handle
oss://bucket.endpointURIsThe community hadoop-aliyun implementation does not support this format
bucket.endpointis treated as the bucket nameThis leads to failures in request signing and endpoint resolution
In our system, OSS access is implemented on top of an S3-compatible protocol, which also cannot recognize bucket.endpoint as a valid bucket identifier.
Problem
When users provide a URI such as:
oss://bucket.endpoint/paththere are two incompatibilities:
The bucket part (bucket.endpoint) is not compatible with S3-style bucket parsing
hadoop-aliyun and S3-compatible implementations do not automatically split the bucket and endpoint
As a result, the same URI behaves differently across implementations, and fails in our current setup.
Solution
This PR introduces an explicit URI rewrite step to align our behavior with JindoFS:
When the scheme is oss:// or s3://
And the bucket is specified in the form bucket.endpoint
Rewrite it into the canonical form:
oss://bucket/pathHTTP and HTTPS URIs are returned unchanged to avoid affecting direct domain-based access.
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)