fix(customize): skip orphaned _raw_data_id rows instead of aborting extraction#8946
Open
danielemoraschi wants to merge 1 commit into
Open
Conversation
…xtraction ExtractCustomizedFields used a LEFT JOIN to the raw table, so a domain row whose _raw_data_id has no matching raw record yields NULL data. That hit the type switch default branch, which did 'return nil' and exited the whole subtask, silently leaving every later row in the (unordered) cursor unprocessed while still reporting success. Change the default branch to 'continue' so an orphaned row is skipped and extraction proceeds with the remaining rows. Closes apache#8945
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtractCustomizedFields used a
LEFT JOINto the raw table, so a domain row whose_raw_data_idhas no matching raw record yieldsNULLdata. That hit the type switch default branch, which didreturn niland exited the whole subtask, silently leaving every later row in the (unordered) cursor unprocessed while still reporting success.Change the default branch to
continueso an orphaned row is skipped and extraction proceeds with the remaining rows.Does this close any open issues?
Closes #8945