Skip to content

Display Data Editor tab name displays file base name - #1524

Merged
stricklandrbls merged 1 commit into
apache:mainfrom
ctc-oss:jy/1523
Nov 10, 2025
Merged

Display Data Editor tab name displays file base name#1524
stricklandrbls merged 1 commit into
apache:mainfrom
ctc-oss:jy/1523

Conversation

@JeremyYao

@JeremyYao JeremyYao commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Closes #1523
Closes #1525

Description

Data Editor Tab now displays the base name of the file

Wiki

  • I have determined that no documentation updates are needed for these changes
    • Rationale: Bug fix
  • I have added following documentation for these changes

Review Instructions including Screenshots

Command Palette

  1. Open the data editor
  2. Cancel selecting a file. Make sure nothing odd happens and an info message pops up on the bottom right
  3. Re-open the data editor
  4. Select a file
  5. Make sure nothing odd happens, verify the tab name is the base name of the file
image
  1. Open another instance of data editor
  2. Try to re-open the same file, verify that the data editor says something about not opening duplicate files

DFDL debugging session

  1. Run a DFDL debugging session with "openDataEditor": true,

Example config you could use:

 {
            "request": "launch",
            "type": "dfdl",
            "name": "Wizard Config",
            "schema": {
                "path": "${command:AskForSchemaName}",
                "rootName": null,
                "rootNamespace": null
            },
            "data": "${command:AskForDataName}",
            "debugServer": 4711,
            "infosetFormat": "xml",
            "infosetOutput": {
                "type": "file",
                "path": "${workspaceFolder}/target/infoset.xml"
            },
            "tdmlConfig": {
                "action": "generate",
                "name": "Default Test Case"
            },
            "trace": true,
            "stopOnEntry": true,
            "useExistingServer": false,
            "openDataEditor": true,
            "openInfosetView": false,
            "openInfosetDiffView": false,
            "daffodilDebugClasspath": [],
            "dataEditor": {
                "port": 9000,
                "logging": {
                    "file": "${workspaceFolder}/dataEditor-${omegaEditPort}.log",
                    "level": "info"
                }
            },
            "dfdlDebugger": {
                "daffodilVersion": "3.11.0",
                "timeout": "10s",
                "logging": {
                    "file": "${workspaceFolder}/daffodil-debugger.log",
                    "level": "INFO"
                }
            }
        }
  1. Verify the data editor tab shows the base file name and nothing odd happens

@JeremyYao JeremyYao self-assigned this Nov 7, 2025
@JeremyYao JeremyYao added bug Something isn't working data editor Issues related to the Data Editor capability labels Nov 7, 2025
@JeremyYao JeremyYao added this to the 1.5.0 milestone Nov 7, 2025
@JeremyYao JeremyYao moved this to In Review in daffodil-vscode v1.5.0 Nov 7, 2025
@stricklandrbls

Copy link
Copy Markdown
Contributor

The Data Editor tests need to be updated to check for the correct panel tab title. The tests currently still have the test expectation of "Data Editor"

@hdalsania hdalsania left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JeremyYao

Copy link
Copy Markdown
Contributor Author

The Data Editor tests need to be updated to check for the correct panel tab title. The tests currently still have the test expectation of "Data Editor"

@stricklandrbls, addressed in 615298c.

@stricklandrbls stricklandrbls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rthomas320 rthomas320 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows 10 works as expected.
+1

@naga-panchumarty naga-panchumarty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stricklandrbls
stricklandrbls merged commit bd2f533 into apache:main Nov 10, 2025
102 of 105 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in daffodil-vscode v1.5.0 Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data editor Issues related to the Data Editor capability

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Start OmegaEdit + Data Editor after file prompt when opening from Command Palette Bug: Data Editor tab name doesn't display file name

5 participants