Display Data Editor tab name displays file base name - #1524
Merged
Conversation
JeremyYao
requested review from
CoverRyan,
hdalsania,
lrbarber,
naga-panchumarty,
rthomas320,
scholarsmate,
shanedell and
stricklandrbls
November 7, 2025 21:13
Contributor
|
The Data Editor tests need to be updated to check for the correct panel tab title. The tests currently still have the test expectation of "Data Editor" |
…dit after file prompt Closes apache#1523 Closes apache#1525
Contributor
Author
@stricklandrbls, addressed in 615298c. |
rthomas320
approved these changes
Nov 10, 2025
rthomas320
left a comment
Contributor
There was a problem hiding this comment.
Tested on Windows 10 works as expected.
+1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1523
Closes #1525
Description
Data Editor Tab now displays the base name of the file
Wiki
Review Instructions including Screenshots
Command Palette
DFDL debugging session
"openDataEditor": true,Example config you could use:
{ "request": "launch", "type": "dfdl", "name": "Wizard Config", "schema": { "path": "${command:AskForSchemaName}", "rootName": null, "rootNamespace": null }, "data": "${command:AskForDataName}", "debugServer": 4711, "infosetFormat": "xml", "infosetOutput": { "type": "file", "path": "${workspaceFolder}/target/infoset.xml" }, "tdmlConfig": { "action": "generate", "name": "Default Test Case" }, "trace": true, "stopOnEntry": true, "useExistingServer": false, "openDataEditor": true, "openInfosetView": false, "openInfosetDiffView": false, "daffodilDebugClasspath": [], "dataEditor": { "port": 9000, "logging": { "file": "${workspaceFolder}/dataEditor-${omegaEditPort}.log", "level": "info" } }, "dfdlDebugger": { "daffodilVersion": "3.11.0", "timeout": "10s", "logging": { "file": "${workspaceFolder}/daffodil-debugger.log", "level": "INFO" } } }