fix: pass partition_key to child PointerModel in fork/spawn relationships#682
Open
andreahlert wants to merge 1 commit intoapache:mainfrom
Open
fix: pass partition_key to child PointerModel in fork/spawn relationships#682andreahlert wants to merge 1 commit intoapache:mainfrom
andreahlert wants to merge 1 commit intoapache:mainfrom
Conversation
…hips The _log_child_relationships function was hardcoding partition_key=None when creating child PointerModels in children.jsonl. This caused the UI to generate broken links for forked/spawned apps that use partition keys, since the route includes the partition_key segment. Closes apache#518
Contributor
Author
|
@elijahbenizzy @skrawcz can you give this a spin and confirm the links are working on your end? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
partition_keyparameter to_log_child_relationshipsso childPointerModelentries inchildren.jsonlhave the correctpartition_keyinstead ofNonepartition_keyfrompost_application_createto_log_child_relationshipschildren.jsonlcontains the correctpartition_keyfor forked appsHow I tested this
test_fork_children_have_correct_partition_keythat creates a parent app with a partition key, forks from it, and asserts the child entry inchildren.jsonlhas the correctpartition_keyNotes
The bug only manifests when
partition_keyis explicitly used in forks. Without it, thenullvalue accidentally matches the UI route, making it seem intermittent.Closes #518