fix: support async with on async persister factory methods#681
Open
andreahlert wants to merge 1 commit intoapache:mainfrom
Open
fix: support async with on async persister factory methods#681andreahlert wants to merge 1 commit intoapache:mainfrom
async with on async persister factory methods#681andreahlert wants to merge 1 commit intoapache:mainfrom
Conversation
`AsyncSQLitePersister.from_values()` and `AsyncPostgreSQLPersister.from_values()` were async classmethods returning coroutines, which cannot be used directly with `async with`. This wraps them in `_AsyncPersisterContextManager` that supports both `await` (backwards compatible) and `async with` protocols. Closes apache#546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #546
AsyncSQLitePersister.from_values()andAsyncPostgreSQLPersister.from_values()are async classmethods that return coroutines. Using them directly withasync withfails with:This PR introduces
_AsyncPersisterContextManager, a thin wrapper that implements both__await__and__aenter__/__aexit__, so factory methods now support both usage patterns:The same fix is applied to
AsyncPostgreSQLPersisterinb_asyncpg.py.Test plan
TypeErrorin a Docker container (Python 3.11)async with ... from_values()works after the fixawait ... from_values()still works (backwards compatibility)