Skip to content

Roll forward io expansion service to Java17#38974

Draft
derrickaw wants to merge 3 commits into
masterfrom
20260615_rollForwardIOExpansionJava17
Draft

Roll forward io expansion service to Java17#38974
derrickaw wants to merge 3 commits into
masterfrom
20260615_rollForwardIOExpansionJava17

Conversation

@derrickaw

Copy link
Copy Markdown
Collaborator

First iteration that was reverted - #38931


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.72%. Comparing base (6ed0635) to head (88ac876).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #38974      +/-   ##
============================================
- Coverage     60.25%   57.72%   -2.54%     
+ Complexity    20572    13032    -7540     
============================================
  Files          3318     2513     -805     
  Lines        315452   261376   -54076     
  Branches      17142    10722    -6420     
============================================
- Hits         190073   150868   -39205     
+ Misses       116830   104796   -12034     
+ Partials       8549     5712    -2837     
Flag Coverage Δ
java 64.22% <ø> (-2.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Java version requirement for the expansion service from Java 11 to Java 17. Specifically, it updates the base Docker image to eclipse-temurin:17 and modifies the Gradle build configuration to require JavaVersion.VERSION_17, noting that Delta Lake requires Java 17+. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@derrickaw derrickaw force-pushed the 20260615_rollForwardIOExpansionJava17 branch 2 times, most recently from 898e6d6 to 5ea0a53 Compare June 16, 2026 16:42
@derrickaw derrickaw force-pushed the 20260615_rollForwardIOExpansionJava17 branch from 5ea0a53 to d8735a1 Compare June 16, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant