-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add support for Apache Flink 2.1.3 #38961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ddebowczyk92
wants to merge
4
commits into
apache:master
Choose a base branch
from
ddebowczyk92:flink-2.1-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d0ff6de
[runners-flink] Add support for Apache Flink 2.1.3
ddebowczyk92 a1d6aa1
Improve lz4-java dependency resolution strategy
ddebowczyk92 b7b4aa5
Fix lz4-java capability conflict for examples:java flinkRunnerPreCommit
ddebowczyk92 b204931
Remove unnecessary test resources for Flink 2.1
ddebowczyk92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * License); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an AS IS BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| project.ext { | ||
| flink_major = '2.1' | ||
| flink_version = '2.1.3' | ||
| excluded_files = [ | ||
| 'main': [ | ||
| // Used by DataSet API only | ||
| "org/apache/beam/runners/flink/adapter/BeamFlinkDataSetAdapter.java", | ||
| "org/apache/beam/runners/flink/FlinkBatchPipelineTranslator.java", | ||
| "org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java", | ||
| "org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java", | ||
| "org/apache/beam/runners/flink/translation/functions/FlinkNonMergingReduceFunction.java", | ||
| // Moved to org.apache.flink.runtime.state.StateBackendFactory | ||
| "org/apache/beam/runners/flink/FlinkStateBackendFactory.java", | ||
| ], | ||
| 'test': [ | ||
| // Used by DataSet API only | ||
| "org/apache/beam/runners/flink/adapter/BeamFlinkDataSetAdapterTest.java", | ||
| "org/apache/beam/runners/flink/batch/NonMergingGroupByKeyTest.java", | ||
| "org/apache/beam/runners/flink/batch/ReshuffleTest.java", | ||
| ] | ||
| ] | ||
| } | ||
|
|
||
| // Load the main build script which contains all build logic. | ||
| apply from: "../flink_runner.gradle" | ||
|
|
||
| // Flink 2.1 uses at.yawk.lz4:lz4-java instead of org.lz4:lz4-java | ||
| // Explicitly prefer Flink's at.yawk.lz4 version to resolve capability conflict | ||
| configurations.all { | ||
| resolutionStrategy.capabilitiesResolution.withCapability('org.lz4:lz4-java') { | ||
| def candidate = candidates.find { it.id.toString().contains('at.yawk.lz4') } | ||
| if (candidate != null) { | ||
| select(candidate) | ||
| } else { | ||
| selectHighestVersion() | ||
| } | ||
| } | ||
| } | ||
|
ddebowczyk92 marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * License); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an AS IS BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| def basePath = '../../job-server-container' | ||
|
|
||
| project.ext { | ||
| resource_path = basePath | ||
| } | ||
|
|
||
| // Load the main build script which contains all build logic. | ||
| apply from: "$basePath/flink_job_server_container.gradle" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * License); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an AS IS BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| def basePath = '../../job-server' | ||
|
|
||
| project.ext { | ||
| // Look for the source code in the parent module | ||
| main_source_dirs = ["$basePath/src/main/java"] | ||
| test_source_dirs = ["$basePath/src/test/java"] | ||
| main_resources_dirs = ["$basePath/src/main/resources"] | ||
| test_resources_dirs = ["$basePath/src/test/resources"] | ||
| archives_base_name = 'beam-runners-flink-2.1-job-server' | ||
| } | ||
|
|
||
| // Load the main build script which contains all build logic. | ||
| apply from: "$basePath/flink_job_server.gradle" | ||
|
|
||
| // Flink 2.1 uses at.yawk.lz4:lz4-java instead of org.lz4:lz4-java | ||
| // Explicitly prefer Flink's at.yawk.lz4 version to resolve capability conflict | ||
| configurations.all { | ||
| resolutionStrategy.capabilitiesResolution.withCapability('org.lz4:lz4-java') { | ||
| def candidate = candidates.find { it.id.toString().contains('at.yawk.lz4') } | ||
| if (candidate != null) { | ||
| select(candidate) | ||
| } else { | ||
| selectHighestVersion() | ||
| } | ||
| } | ||
| } | ||
|
ddebowczyk92 marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this chunk do?
Is it due to https://issues.apache.org/jira/browse/FLINK-38764?
We don't need this workaround in examples/java. If we really want to patch it, it should happens in module that ships for production (runners/flink/2.1). Here it's just Java examples where handling CVEs doesn't adds much value
If it's required to make Flink 2.1 working it's more concerning, as it indicates users would need the same hack here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that Flink 2.1+ comes with
at.yawk.lz4:lz4-javainstead oforg.lz4:lz4-java. This becomes an issue in modules where both libraries are present; this change simply favors the former.In the case of this specific module, the conflict arises because of the
kafka-clientsdependency, which brings in the old version oforg.lz4.The parents of the clashing dependencies can be checked via this command:
./gradlew :examples:java:dependencies --configuration flinkRunnerPreCommit | grep -B2 "org.lz4:lz4-java:1.6.0"I made these changes to pass the
./gradlew :javaPreCommitCICD check