feat: rate limiting plugins support setting keepalive for redis policy #12861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Baoyuantop
reviewed
Jan 7, 2026
| local delay, incoming_err = util.incoming(self, red, key, commit) | ||
| local ok, err = red:set_keepalive(conf.keepalive_timeout, conf.keepalive_pool) | ||
| if not ok then | ||
| core.log.error("set keepalive failed:", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| core.log.error("set keepalive failed:", err) | |
| core.log.error("set keepalive failed: ", err) |
apisix/utils/rediscluster.lua
Outdated
| local config = { | ||
| name = conf.redis_cluster_name, | ||
| serv_list = {}, | ||
| keepalive_timeout = conf.keepalive_timeout, --redis connection pool idle timeout |
Contributor
There was a problem hiding this comment.
Suggested change
| keepalive_timeout = conf.keepalive_timeout, --redis connection pool idle timeout | |
| keepalive_timeout = conf.keepalive_timeout, -- redis connection pool idle timeout |
apisix/utils/rediscluster.lua
Outdated
| name = conf.redis_cluster_name, | ||
| serv_list = {}, | ||
| keepalive_timeout = conf.keepalive_timeout, --redis connection pool idle timeout | ||
| keepalive_cons = conf.keepalive_pool, --redis connection pool size |
Contributor
There was a problem hiding this comment.
Suggested change
| keepalive_cons = conf.keepalive_pool, --redis connection pool size | |
| keepalive_cons = conf.keepalive_pool, -- redis connection pool size |
t/plugin/limit-conn-redis.t
Outdated
| if err then | ||
| core.log.error("failed to create redis cli: ", err) | ||
| ngx.say("failed to create redis cli: ", err) | ||
| return nil,err |
Contributor
There was a problem hiding this comment.
Suggested change
| return nil,err | |
| return nil, err |
Contributor
There was a problem hiding this comment.
Please update the English document simultaneously.
Baoyuantop
added
the
wait for update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
redis_timeoutonly applies tosend_timeout. This pr will make the values ofconnect_timeoutandsend_timeoutconsistent withredis_timeout.Which issue(s) this PR fixes:
relate issue: #12817
Checklist