Fix navigation for 3 dot menu in EditorModal#2875
Open
MohitMandalia wants to merge 1 commit intoanyproto:mainfrom
Open
Fix navigation for 3 dot menu in EditorModal#2875MohitMandalia wants to merge 1 commit intoanyproto:mainfrom
MohitMandalia wants to merge 1 commit intoanyproto:mainfrom
Conversation
MohitMandalia
requested review from
konstantiniiv and
uburoiubu
as code owners
Author
|
This is a fix based on if the EditorFragment is loaded inside of EditorModal or Standalone. Can also make changes to make it better but if this is to be replaced by compose soon than this should do. I can discuss and make changes according to your suggestions. Thanks Team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 3-dot -menu of the template editing -window cannot be opened.
Issue
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?