nodeconf: configuration epochs, change observers, config history store#721
Open
cheggaaa wants to merge 1 commit into
Open
nodeconf: configuration epochs, change observers, config history store#721cheggaaa wants to merge 1 commit into
cheggaaa wants to merge 1 commit into
Conversation
…y store - Configuration.Epoch: monotonic version set by the coordinator (0 = pre-epoch) - NetworkConfigurationResponse.epoch in coordinatorproto (+ regen) - nodeconf.Service.ObserveChanges: observers notified on config replacement - nodeconf.HistoryStore + nodeconfstore retains last 100 epochs per network Groundwork for tree-node resharding (see any-sync-node docs/resharding-plan.md). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KDgytoFFikB7tY4oRreWom
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for tree-node resharding (design: any-sync-node docs/resharding-plan.md).
Changes
Configuration.Epoch: monotonically increasing version assigned by the coordinator on every publish (0 = pre-epoch configs); exposed via a newepochfield inNetworkConfigurationResponse(+ regenerated coordinatorproto).nodeconf.Service.ObserveChanges(observer): observers are called with the previous and newNodeConfwhenever the active configuration is replaced (not for the initial one). The node's resharder uses this to trigger drain cycles immediately instead of waiting for a periodic timer.nodeconf.HistoryStore(optionalStoreextension) + implementation innodeconfstore: retains the last 100 epochs per network on disk. Used by nodes to recompute earlier rings after a restart mid-migration and to authenticate draining nodes that were already removed from the current configuration.Companion PRs
Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01KDgytoFFikB7tY4oRreWom