Skip to content

Jess/608 chk url #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjwgit merged 5 commits into from
Mar 13, 2026
Merged

Jess/608 chk url #609

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7fe5c06
add url parse check requirement
jesscmoore Mar 11, 2026
206585c
Merge branch 'dev' into jess/608_chk_url
jesscmoore Mar 11, 2026
c92fca2
remove url debugprint
jesscmoore Mar 12, 2026
64c1998
corrected the url check of resource name
jesscmoore Mar 13, 2026
bcf5f16
added doc
jesscmoore Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/src/solid/utils/get_url_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
///
/// Authors: Anushka Vidanage, Dawei Chen
/// Authors: Anushka Vidanage, Dawei Chen, Jess Moore

library;

Expand Down Expand Up @@ -110,8 +110,10 @@ Future<String> filenameToResourceUrl({
isFileUrl = true;
}

// If not already a url, get url
if (!isExternalRes && !isFileUrl) {
// If resource name lacks a url scheme, is not an
// externally owned resource and is not already
// declared as a url, then form url from resource name
if (!Uri.parse(fileName).hasScheme && !isExternalRes && !isFileUrl) {
// Get the file path
// Ensure path uses correct path separators and
// has app data dir prepended.
Expand Down
Loading