Skip to content

Jess/380 common icon#383

Merged
jesscmoore merged 7 commits intodevfrom
jess/380_common_icon
Mar 19, 2026
Merged

Jess/380 common icon#383
jesscmoore merged 7 commits intodevfrom
jess/380_common_icon

Conversation

@jesscmoore
Copy link
Collaborator

@jesscmoore jesscmoore commented Mar 18, 2026

Pull Request Details

Description

Disables multi note delete button if external note in selection, and makes all note selection icons the same

Related Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Notepod, select and select user owned and externally owned notes.
Hover over and click delete button

Checklist

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@jesscmoore jesscmoore merged commit a6d6eb3 into dev Mar 19, 2026
20 checks passed
@jesscmoore jesscmoore deleted the jess/380_common_icon branch March 19, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant