Skip to content

Conversation

@lzxue
Copy link

@lzxue lzxue commented Jan 26, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @lzxue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求引入了一个全面的 L7 技能库,旨在通过结构化的文档和元数据,极大地提升 AntV L7 地理空间可视化引擎的开发效率和 AI 模型集成能力。它详细阐述了 L7 的各项功能,从基础的场景初始化到复杂的数据处理、图层渲染、交互设计、动画效果、性能优化和视觉映射,为用户和 AI 模型提供了清晰的指导和丰富的代码示例。

Highlights

  • 新增 L7 技能库: 引入了一个全新的 L7 技能库,旨在为 AntV L7 地理空间可视化引擎提供结构化的技能知识库,遵循 skill-creator 的最佳实践。
  • 详细文档与设计原则: 技能库设计遵循渐进式披露和按领域组织原则,包含 SKILL.md 作为概览和快速入门,以及 references/ 目录下按核心功能、数据处理、图层类型、交互组件、动画效果、性能优化和视觉映射等领域组织的详细文档。
  • AI 模型集成支持: 为 AI 模型提供了三级加载系统和文档选择策略,并支持技能组合模式,以便 AI 模型能更高效地理解和生成 L7 相关代码。同时,新增了 metadata/ 目录,包含技能依赖关系、中英文标签和版本兼容性信息,以辅助 AI 模型进行检索和理解。
  • 全面的 L7 功能覆盖: 新增了 L7 核心功能(场景初始化)、数据处理(GeoJSON、CSV、JSON、数据解析配置)、图层类型(热力图、图片图层、线图层、点图层、面图层、栅格瓦片图层)、交互组件(Popup、Marker、Controls、Legend)、动画效果(图层动画、轨迹动画)、性能优化和视觉映射(颜色、大小、形状映射、样式配置)等多个方面的详细技能文档和代码示例。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 为 AntV L7 新增了完整的技能知识库,整体结构清晰,遵循了 skill-creator 的最佳实践,内容覆盖全面。然而,在多个文档文件中存在一些内容重复、格式错误和链接失效的问题,这可能是由于文件结构重构导致的。建议在合并前修复这些问题,以保证文档的质量和可用性。我在具体的 review comments 中指出了需要修正的地方。

Comment on lines 280 to 357
document.addEventListener('DOMContentLoaded', () => {
const scene = new Scene({
id: 'map',
map: new GaodeMap({...})
});
});

````

### 2. 高德地图 Key 配置

高德地图需要申请 Key:

```javascript
import { GaodeMap } from '@antv/l7-maps';

const scene = new Scene({
id: 'map',
map: new GaodeMap({
style: 'dark',
center: [120, 30],
zoom: 10,
token: 'your-amap-key' // 高德地图 Key
})
});
````

### 3. 地图未显示

**检查清单**:

- ✅ 容器是否有高度(必须设置具体高度,不能为 0)
- ✅ 是否正确引入了底图库
- ✅ 控制台是否有错误信息
- ✅ 网络是否正常(在线底图需要联网)

### 4. 坐标系统

L7 使用 **WGS84** 坐标系统(经纬度):

- 经度范围: -180 ~ 180
- 纬度范围: -90 ~ 90
- 格式: [经度, 纬度] 或 [lng, lat]

中国常用城市坐标参考:

- 北京: [116.404, 39.915]
- 上海: [121.473, 31.230]
- 杭州: [120.155, 30.274]
- 深圳: [114.057, 22.543]

## 场景生命周期事件

```javascript
// 场景加载完成
scene.on('loaded', () => {
console.log('场景加载完成');
});

// 场景销毁
scene.on('destroy', () => {
console.log('场景已销毁');
});
```

## 相关技能

- [场景生命周期管理](./scene-lifecycle.md)
- [场景方法](./scene-methods.md)
- [添加图层](../03-layers/point-layer.md)

## 下一步

场景初始化完成后,你可以:

1. [添加点图层显示数据](../03-layers/point-layer.md)
2. [添加交互控件](../06-components/controls.md)
3. [处理用户交互事件](../05-interaction/event-handling.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

  1. 内容重复: 从第280行开始,常见问题部分的内容与前面重复。建议移除从280行到330行的重复内容。
  2. 链接失效: 第347-349行的相关技能链接使用了旧的目录结构或指向了不存在的文件。例如:
    • ./scene-lifecycle.md./scene-methods.md 文件似乎不存在。
    • ../03-layers/point-layer.md 应该更新为 ../layers/point.md
      请检查并修正这些链接,确保它们指向正确的位置。

lzxue and others added 11 commits January 26, 2026 15:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@lzxue lzxue changed the title feat: 添加 l7 map skills WIP feat: 添加 l7 map skills Jan 26, 2026
@hustcc
Copy link
Member

hustcc commented Jan 26, 2026

这个文档,现在是从 L7 文档库中 cp 过来的吧?

@lzxue
Copy link
Author

lzxue commented Jan 26, 2026

这个文档,现在是从 L7 文档库中 cp 过来的吧?

对啊,想搞个自动同步 ci,还有些问题

@hustcc
Copy link
Member

hustcc commented Jan 26, 2026

那先 hold 一下,sive 发布后,年后看看 antv 各个技术栈的 Skill 看看有没有统一的规范和要求。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants