-
Notifications
You must be signed in to change notification settings - Fork 1
WIP feat: 添加 l7 map skills #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @lzxue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求引入了一个全面的 L7 技能库,旨在通过结构化的文档和元数据,极大地提升 AntV L7 地理空间可视化引擎的开发效率和 AI 模型集成能力。它详细阐述了 L7 的各项功能,从基础的场景初始化到复杂的数据处理、图层渲染、交互设计、动画效果、性能优化和视觉映射,为用户和 AI 模型提供了清晰的指导和丰富的代码示例。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 为 AntV L7 新增了完整的技能知识库,整体结构清晰,遵循了 skill-creator 的最佳实践,内容覆盖全面。然而,在多个文档文件中存在一些内容重复、格式错误和链接失效的问题,这可能是由于文件结构重构导致的。建议在合并前修复这些问题,以保证文档的质量和可用性。我在具体的 review comments 中指出了需要修正的地方。
skills/l7/references/core/scene.md
Outdated
| document.addEventListener('DOMContentLoaded', () => { | ||
| const scene = new Scene({ | ||
| id: 'map', | ||
| map: new GaodeMap({...}) | ||
| }); | ||
| }); | ||
|
|
||
| ```` | ||
|
|
||
| ### 2. 高德地图 Key 配置 | ||
|
|
||
| 高德地图需要申请 Key: | ||
|
|
||
| ```javascript | ||
| import { GaodeMap } from '@antv/l7-maps'; | ||
|
|
||
| const scene = new Scene({ | ||
| id: 'map', | ||
| map: new GaodeMap({ | ||
| style: 'dark', | ||
| center: [120, 30], | ||
| zoom: 10, | ||
| token: 'your-amap-key' // 高德地图 Key | ||
| }) | ||
| }); | ||
| ```` | ||
|
|
||
| ### 3. 地图未显示 | ||
|
|
||
| **检查清单**: | ||
|
|
||
| - ✅ 容器是否有高度(必须设置具体高度,不能为 0) | ||
| - ✅ 是否正确引入了底图库 | ||
| - ✅ 控制台是否有错误信息 | ||
| - ✅ 网络是否正常(在线底图需要联网) | ||
|
|
||
| ### 4. 坐标系统 | ||
|
|
||
| L7 使用 **WGS84** 坐标系统(经纬度): | ||
|
|
||
| - 经度范围: -180 ~ 180 | ||
| - 纬度范围: -90 ~ 90 | ||
| - 格式: [经度, 纬度] 或 [lng, lat] | ||
|
|
||
| 中国常用城市坐标参考: | ||
|
|
||
| - 北京: [116.404, 39.915] | ||
| - 上海: [121.473, 31.230] | ||
| - 杭州: [120.155, 30.274] | ||
| - 深圳: [114.057, 22.543] | ||
|
|
||
| ## 场景生命周期事件 | ||
|
|
||
| ```javascript | ||
| // 场景加载完成 | ||
| scene.on('loaded', () => { | ||
| console.log('场景加载完成'); | ||
| }); | ||
|
|
||
| // 场景销毁 | ||
| scene.on('destroy', () => { | ||
| console.log('场景已销毁'); | ||
| }); | ||
| ``` | ||
|
|
||
| ## 相关技能 | ||
|
|
||
| - [场景生命周期管理](./scene-lifecycle.md) | ||
| - [场景方法](./scene-methods.md) | ||
| - [添加图层](../03-layers/point-layer.md) | ||
|
|
||
| ## 下一步 | ||
|
|
||
| 场景初始化完成后,你可以: | ||
|
|
||
| 1. [添加点图层显示数据](../03-layers/point-layer.md) | ||
| 2. [添加交互控件](../06-components/controls.md) | ||
| 3. [处理用户交互事件](../05-interaction/event-handling.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
这个文档,现在是从 L7 文档库中 cp 过来的吧? |
对啊,想搞个自动同步 ci,还有些问题 |
|
那先 hold 一下,sive 发布后,年后看看 antv 各个技术栈的 Skill 看看有没有统一的规范和要求。 |
No description provided.