Conversation
Apply getTheme() consistently across all G6-based charts (fishbone-diagram, flow-diagram, indented-tree, mindmap, network-graph, organization-chart), fix theme count in docs site, expand network-graph and dual-axes config docs, and clarify summary generation instructions in SKILL.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Academy theme uses sharp corners (radius 0) for a more formal style. Applied to fishbone-diagram, flow-diagram, indented-tree, mindmap, organization-chart, dual-axes, and waterfall. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
🎊 PR Preview 24cb47c has been successfully built and deployed to https://antvis-GPT-Vis-preview-pr-408.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the theme system by consolidating the 'light' theme into 'default' and introducing specific styling logic for the 'academy' theme across multiple visualization types, including DualAxes, Fishbone, Flow, IndentedTree, Mindmap, and Organization charts. Documentation for DualAxes and NetworkGraph has been expanded, and the requirements for the 'summary' type have been clarified. Feedback identifies a bug in the FlowDiagram where dynamic node size measurements are overridden by hardcoded values in the style callback, and a layout issue in the IndentedTree where new root node padding may cause background overflow due to an insufficient size buffer.
The node.style callback always returned hardcoded DEFAULT_NODE_HEIGHT, overriding measured heights set by measureAndUpdateNodeSizes on re-render. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 participants
ref: #368
统一无圆角的学术风格：
