Skip to content

refactor: simplify Spreadsheet API by removing autoFit and title props#273

Merged
hustcc merged 8 commits intofeat/s2from
copilot/sub-pr-265
Jan 21, 2026
Merged

refactor: simplify Spreadsheet API by removing autoFit and title props#273
hustcc merged 8 commits intofeat/s2from
copilot/sub-pr-265

Conversation

Copy link
Contributor

Copilot AI commented Jan 21, 2026

  • Remove autoFit prop from Spreadsheet component (keep logic, default to true)
  • Remove title prop and UI from Spreadsheet component
  • Update demo files to remove title prop usage
  • Update documentation to remove title and autoFit from API
  • Update test specs to remove title prop
  • Run tests and update unit test screenshots
  • Fix CI/lint error (formatting issue in pivot demo)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 21, 2026
3 tasks
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

⚠️ No Changeset found

Latest commit: 55ec34b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI and others added 3 commits January 21, 2026 06:50
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
@hustcc hustcc marked this pull request as ready for review January 21, 2026 06:58
@hustcc hustcc requested a review from Alexzjt January 21, 2026 06:58
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

🎊 PR Preview 55ec34b has been successfully built and deployed to https://antvis-GPT-Vis-preview-pr-273.surge.sh

🕐 Build time: 19.263s

🤖 By surge-preview

Copy link
Contributor Author

Copilot AI commented Jan 21, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • gw.alipayobjects.com
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1200/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1200/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD odules/.bin/ldd d -n 10 (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/143.0.7499.4/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/GPT-Vis/GPT-Vis/node_modules/.pnpm/playwright-core@1.57.0/node_modules/playwright-core/lib/server/registry/oopDownloadBrowserMain.js (http block)
  • https://storage.googleapis.com/chrome-for-testing-public/143.0.7499.4/linux64/chrome-linux64.zip
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/GPT-Vis/GPT-Vis/node_modules/.pnpm/playwright-core@1.57.0/node_modules/playwright-core/lib/server/registry/oopDownloadBrowserMain.js (http block)
  • unpkg.com
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1200/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1200/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD odules/.bin/ldd d -n 10 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add spreadsheet component with documentation and tests refactor: simplify Spreadsheet API by removing autoFit and title props Jan 21, 2026
Copilot AI requested a review from hustcc January 21, 2026 07:00
@hustcc
Copy link
Member

hustcc commented Jan 21, 2026

@copilot fix the CI / ling error.

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 21, 2026

@copilot fix the CI / ling error.

Fixed in commit 738eaf6. The issue was a Prettier formatting error in pivot.tsx where the JSX needed to be on a single line instead of multi-line.

@hustcc
Copy link
Member

hustcc commented Jan 21, 2026

@copilot 去掉 SpreadsheetWrapper,把剩余的 container 样式直接写到 div 上,这样简化一下代码,也可以去除 style-component 依赖。

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 21, 2026

@copilot 去掉 SpreadsheetWrapper,把剩余的 container 样式直接写到 div 上,这样简化一下代码,也可以去除 style-component 依赖。

Done in commit 660763b. Removed SpreadsheetWrapper styled component and applied container styles directly using inline styles (style={{ width: '100%', height: '100%' }}). This eliminates the styled-components import from the Spreadsheet component.

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
@hustcc
Copy link
Member

hustcc commented Jan 21, 2026

@copilot revert 660763b

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 21, 2026

@copilot revert 660763b

Reverted in commit 55ec34b. Restored the styled-components approach with SpreadsheetWrapper and removed the inline styles from the previous commits.

@hustcc hustcc merged commit 4e21f66 into feat/s2 Jan 21, 2026
7 of 8 checks passed
@hustcc hustcc deleted the copilot/sub-pr-265 branch January 21, 2026 07:49
hustcc added a commit that referenced this pull request Jan 27, 2026
* chore: update s2-ssr version

* feat: 增加Spreadsheet组件

* test: 提交截图

* fix: 不能加到 default 里面,会增加大小,建议和 L7 地图一样,不内置,用户需要的时候自己加载!

* chore: 提交changeset

* fix: 构建问题

* test: 高度正常不留这么大空白

* Initial plan

* refactor: remove autoFit and title props from Spreadsheet component

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* test: remove title prop from test specs

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* test: update unit test screenshot for dark theme

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* fix: format pivot demo to match prettier style

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* refactor: simplify Spreadsheet API by removing autoFit and title props (#273)

* Initial plan

* refactor: remove autoFit and title props from Spreadsheet component

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* test: remove title prop from test specs

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* test: update unit test screenshot for dark theme

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* fix: format pivot demo to match prettier style

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* refactor: remove styled-components dependency from Spreadsheet

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* fix: use width/height props in inline styles

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* revert: restore styled-components in Spreadsheet component

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

* test: 修复 CI 问题

* test: 修复 CI 问题

---------

Co-authored-by: hustcc <i@hust.cc>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants