refactor: simplify Spreadsheet API by removing autoFit and title props#273
refactor: simplify Spreadsheet API by removing autoFit and title props#273
Conversation
|
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
|
🎊 PR Preview 55ec34b has been successfully built and deployed to https://antvis-GPT-Vis-preview-pr-273.surge.sh 🕐 Build time: 19.263s 🤖 By surge-preview |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot fix the CI / ling error. |
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
|
@copilot 去掉 SpreadsheetWrapper,把剩余的 container 样式直接写到 div 上,这样简化一下代码,也可以去除 style-component 依赖。 |
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Done in commit 660763b. Removed |
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
* chore: update s2-ssr version * feat: 增加Spreadsheet组件 * test: 提交截图 * fix: 不能加到 default 里面,会增加大小,建议和 L7 地图一样,不内置,用户需要的时候自己加载! * chore: 提交changeset * fix: 构建问题 * test: 高度正常不留这么大空白 * Initial plan * refactor: remove autoFit and title props from Spreadsheet component Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * test: remove title prop from test specs Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * test: update unit test screenshot for dark theme Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * fix: format pivot demo to match prettier style Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * refactor: simplify Spreadsheet API by removing autoFit and title props (#273) * Initial plan * refactor: remove autoFit and title props from Spreadsheet component Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * test: remove title prop from test specs Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * test: update unit test screenshot for dark theme Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * fix: format pivot demo to match prettier style Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * refactor: remove styled-components dependency from Spreadsheet Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * fix: use width/height props in inline styles Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * revert: restore styled-components in Spreadsheet component Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com> * test: 修复 CI 问题 * test: 修复 CI 问题 --------- Co-authored-by: hustcc <i@hust.cc> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

autoFitprop from Spreadsheet component (keep logic, default to true)titleprop and UI from Spreadsheet component💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.