Add 'full-file' support, getopt, verbose.#7
Open
mino98 wants to merge 1 commit intoantonlindstrom:masterfrom
mino98:full-file
Open
Add 'full-file' support, getopt, verbose.#7mino98 wants to merge 1 commit intoantonlindstrom:masterfrom mino98:full-file
mino98 wants to merge 1 commit intoantonlindstrom:masterfrom
mino98:full-file
Conversation
antonlindstrom
requested changes
Feb 27, 2018
Owner
antonlindstrom
left a comment
antonlindstrom
left a comment
There was a problem hiding this comment.
Thanks for this! I am however unable to get the changes to test locally since the source is removed.
| # Help: | ||
| function usage() { | ||
| echo "Usage: $0 [-h] [-v] [-f]" 1>&2; | ||
| exit 1; |
Owner
There was a problem hiding this comment.
What do you think about returning 0 here? I looked at vim -h, gdb -h and cmake -h and they seem to all return 0 for help.
|
|
||
| # Help: | ||
| function usage() { | ||
| echo "Usage: $0 [-h] [-v] [-f]" 1>&2; |
Owner
There was a problem hiding this comment.
Do you mind adding some description of what the flag do? For example that I should not run -v in front of someone else since they might see all of my passwords.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding minimal getopt support:
If you enable "full-file mode" (
-f) then every line of the file is checked against passpwn, rather than just the first line. This is obviously much slower but potentially helpful for messy people like myself, if you have credentials in line other than the first of each file.Verbose (
-v) prints the current file and string, for debugging.Works on MacOS and should work on Linux, but I haven't tried it and OSX
getoptis different from linux's.