fix(@types): improve types of DiagramNode

[kei711]

Description

• Fixed argument type of render props in Node

Related Issue

Motivation and Context

How Has This Been Tested?

yarn test-types

Screenshots (if appropriate):

❯ yarn test-types
yarn run v1.22.5
$ npx tsc -p . --noEmit
✨  Done in 3.28s.

[kei711]

https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/DiagramNode/DiagramNode.js#L59

[antonioru]

Hello @kei711

thank you very much for your contribution, it looks great... I'm not a TS expert so I ask for the help of @9renpoto on this as he improved the exported types part.

[9renpoto]

LGTM :)

@antonioru thank you review!

[kresli]

any updates on this?

[kresli]

actually, I think this is still missing style prop

[kresli]

All works if we change it to

export type NodeRenderProps<P> = Omit<
  Node<P>,
  'coordinates' | 'disableDrag' | 'inputs' | 'outputs'
> & { 
  inputs: ReactElement<Port & HTMLAttributes<HTMLDivElement>>[]; 
  outputs: ReactElement<Port & HTMLAttributes<HTMLDivElement>>[] 
};

[kei711]

Hi @kresli, thanks for the feedback.
I've committed your suggestion in 57dbbff.

[kei711]

refs:
https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/DiagramNode/DiagramNode.js#L59
https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/Port/Port.js#L48