Skip to content

feat: added DiagramCanvas types#76

Open
9renpoto wants to merge 2 commits intoantonioru:masterfrom
caddijp:fix/types
Open

feat: added DiagramCanvas types#76
9renpoto wants to merge 2 commits intoantonioru:masterfrom
caddijp:fix/types

Conversation

@9renpoto
Copy link
Copy Markdown
Contributor

Description

added DiagramCavans type definitions

Related Issue

related #48

Motivation and Context

How Has This Been Tested?

yarn test-types

Screenshots (if appropriate):


validateSchema(schema); // returns true or throw an error
validateNodes(schema.nodes); // returns true or throw an error
validateNode(schema.nodes[0); // returns true or throw an error
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@antonioru
Copy link
Copy Markdown
Owner

Hello @9renpoto
I'm very glad to have your contribution, thank you for adding the correct types to the Diagram component.
At the moment, due to this serious bug [ #78 ] I would very much appreciate if you can possibly wait the version 0.6.0 before typing the pan/zoom API.
Actually there's already an PR (it's a working in progress) to possibly solve the #78 as soon as possible: #70

@antonioru antonioru self-requested a review November 25, 2020 12:28
@antonioru antonioru self-assigned this Nov 25, 2020
@antonioru antonioru added enhancement New feature or request typescript Something is wrong with the Types labels Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request typescript Something is wrong with the Types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants