feat: Pydantic v2 upgrade#388
Open
lmmx wants to merge 1 commit intoantonagestam:mainfrom
Open
Conversation
b54f2e1 to
0201708
Compare
This comment was marked as resolved.
This comment was marked as resolved.
29a6af7 to
f8d1697
Compare
f8d1697 to
c07fe39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discussed the approach a little here #286 (comment)
Conditional imports
This PR introduces a hard import on pydantic and pydantic core in 4 modules (
{_base,sized,schema,negated}.py).TYPE_CHECKING, which I did too. (For instance, someone with pydantic installed but not using the pydantic parts of this library shouldn't "pay" for the time to import pydantic)MissingDependencyerror in a nice way, without having to repeat it everywhereChecklist
make testgoose run --select=all