feat: career_pages feature flag in inertia footer and nav#3585
feat: career_pages feature flag in inertia footer and nav#3585alina-alyy wants to merge 3 commits intoantiwork:mainfrom
career_pages feature flag in inertia footer and nav#3585Conversation
alina-alyy
had a problem deploying
to
ci-protected
GitHub Actions
Error
|
|
||
| export const HomeFooter = () => ( | ||
| export const HomeFooter = () => { | ||
| const { career_pages } = useFeatureFlags(); |
There was a problem hiding this comment.
Using useFeatureFlags() hook instead of manually passing prop to keep things consistent
| disable_stripe_signup: false, | ||
| career_pages: false |
There was a problem hiding this comment.
Updated test to ensure the career_pages is correctly included in the shared context.
| feature_flags: { | ||
| require_email_typo_acknowledgment: Feature.active?(:require_email_typo_acknowledgment), | ||
| disable_stripe_signup: Feature.active?(:disable_stripe_signup), | ||
| career_pages: Feature.active?(:career_pages), |
There was a problem hiding this comment.
Updated the rendering extension to pass the backend feature flag status to the frontend.
alina-alyy
had a problem deploying
to
ci-protected
GitHub Actions
Error
| <FooterLink href={Routes.pricing_path()}>Pricing</FooterLink> | ||
| <FooterLink href={Routes.features_path()}>Features</FooterLink> | ||
| <FooterLink href={Routes.about_path()}>About</FooterLink> | ||
| {career_pages && <FooterLink href={Routes.careers_path()}>Careers</FooterLink>} |
There was a problem hiding this comment.
Conditionally rendering the careers page to match original ERB implementation
|
The issue exist in the |
alina-alyy
requested a deployment
to
ci-protected
GitHub Actions
Waiting
| { href: Routes.pricing_path(), label: "Pricing" }, | ||
| { href: Routes.features_path(), label: "Features" }, | ||
| { href: Routes.about_path(), label: "About" }, | ||
| ...(career_pages ? [{ href: Routes.careers_path(), label: "Careers" }] : []), |
alina-alyy
changed the title
career_pages feature flag in inertia footercareer_pages feature flag in inertia footer and nav
|
Thanks for the contribution! The issue this PR is linked to still has a "planning" label, which means it's still being scoped by our team and isn't ready for a PR yet. We're closing this for now — please find an open issue without a "planning" label and we'd love your help there. We appreciate it! |
3 participants
Issue: #3561
Description
Problem
The Careers link was missing from the React footer because the
career_pagesfeature flag wasn't passed from Rails or defined in the React context.Solution
Exposed the
career_pagesflag inreact_on_rails.rband the ReactFeatureFlagscontext, then updated the React footer to conditionally render the Careers link based on that flag.Before/After
Before
After
Fixed conditionally rendering for
career_pagesfeature flag in bothNavandFooterTest Results
bundle exec rspec spec/config/rendering_extension_spec.rbChecklist
AI Disclosure
Used Claude Opus 4.6 for debugging