fix: make VsagException public inherit from std::exception#1787
Open
fix: make VsagException public inherit from std::exception#1787
Conversation
Move max_capacity assignment after io->Write() to ensure data is persisted before updating capacity. Co-Authored-By: Claude <[email protected]> Signed-off-by: jinjiabao.jjb <[email protected]>
The class was using private inheritance which prevented catching VsagException with std::exception handler, breaking standard C++ exception handling patterns. Signed-off-by: jinjiabao.jjb <[email protected]>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the VsagException class to use public inheritance from std::exception and reorders the catch blocks in Engine::CreateIndex to ensure that the more specific VsagException is caught before the general std::exception. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## 0.17 #1787 +/- ##
==========================================
- Coverage 91.90% 91.46% -0.44%
==========================================
Files 318 318
Lines 17758 17758
==========================================
- Hits 16320 16243 -77
- Misses 1438 1515 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of PR #1776 to branch 0.17
catch (std::exception& e)handlers, following standard C++ exception handling patternsProblem
The class was using private inheritance (default for class):
This prevented catching VsagException with std::exception handler, breaking standard exception handling.
Solution
Changed to public inheritance:
And reordered catch blocks to ensure derived class (VsagException) is caught before base class (std::exception).
Changes
src/vsag_exception.h: Changed to public inheritancesrc/factory/engine.cpp: Reordered catch blocks (VsagException before std::exception)Impact