Ignore reserved VLANs 1002-1005 for state overridden#1224
Open
jiholland wants to merge 32 commits intoansible-collections:mainfrom
Open
Ignore reserved VLANs 1002-1005 for state overridden#1224jiholland wants to merge 32 commits intoansible-collections:mainfrom
jiholland wants to merge 32 commits intoansible-collections:mainfrom
Conversation
for more information, see https://pre-commit.ci
Ruchip16
reviewed
Aug 14, 2025
| excluded_vlans = {k: v for k, v in iteritems(haved) if k not in wantd or not wantd} | ||
| haved = {k: v for k, v in iteritems(haved) if k in wantd or not wantd} | ||
| for k, have in iteritems(excluded_vlans): | ||
| # Skip reserved VLANs 1002–1005 |
Contributor
There was a problem hiding this comment.
why are we skipping these?
Author
There was a problem hiding this comment.
Because they can’t be deleted, which breaks idempotency for state overridden.
Contributor
There was a problem hiding this comment.
ok can we add some tests for this?
Author
There was a problem hiding this comment.
What type of test?
This is the issue I’m trying to solve: #1182
Contributor
There was a problem hiding this comment.
integration/unit tests maybe
Author
There was a problem hiding this comment.
I have updated the unit/integration tests and documentation to reflect the changes. Would be nice if you, @Ruchip16 , could take a look at it again. Thanks.
Collaborator
There was a problem hiding this comment.
Hey @jiholland I am taking a look at this.
Will update shortly
Author
There was a problem hiding this comment.
Thanks @KB-perByte . Idempotency with state overridden is still an issue, and it would be great if it could be resolved. It does not have to be this exact fix, but some solution to the problem would be nice.
Contributor
|
CI is failing |
for more information, see https://pre-commit.ci
* minor_changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update commit_conf.yaml * Update commit_conf.yaml * Update commit_conf.yaml * Update tests/integration/targets/ios_cliconf/tests/common/commit_conf.yaml * added_pexpect * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update cli_test.yml --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sagar Paul <[email protected]>
…state (ansible-collections#1227) * minor_fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update static_routes.yml * Update test_ios_static_routes.py * fixes_integration_test * reverting_tests_changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* minor_changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update vrf_global.py * fixes_lint_errors * fixes_lint_errors * Update .ansible-lint * Update .ansible-lint * fix_lint_errors * fixing_lint_erros * reverting_the_changes_of_lint_file --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…#1229) * Added in chassis_id to net neighbours * added test for chassis_id in lldp neighbours. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added changelog fragment --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sagar Paul <[email protected]>
* fix_ios_bgp_address_family * minor_fix * minor_fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update commit_conf.yaml * added_integration_tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update bgp_address_family.yml * Update bgp_address_family.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…-collections#1232) * Added prompt and answer funtinalities to ios config module * added robustness to code * added description about line , prompt and answer * added robustness to code * removed traceback * added unit tests * added integration tests * added changelog * addressed review comments * fixed sanity * fixed sanity * fixed sanity * fixed sanity * fixed sanity * fixed test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update prompt.yaml * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sagar Paul <[email protected]>
…tions#1240) * ipv6 handling issues with ios_hsrp_interface * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix state and defaults * update defaults and tasks * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * only apply version if standby is present * Update fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix tests * fix sanity * Update pre-commit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Ignore VLAN 1002-1005 for state overridden
ISSUE TYPE
#1182