fix(core): markdown link labels not clickable#888
fix(core): markdown link labels not clickable#888AnatoleLucet wants to merge 1 commit intoanomalyco:mainfrom
Conversation
|
Can you make this test use the real highlight format tree-sitter returns here? Right now it uses synthetic concealed ranges, but markdown conceal output is conceal with |
|
i think its just but i'll update the tests to use a real treesitter output so we're sure it works and wont break again :) |
|
there's a separate issue on since this probably never worked, should i remove the test? i pushed the failing test but the rest is good. let me know how you want to proceed :) |
|
No, i think the fix was good. |
relevant log in ci: https://github.com/anomalyco/opentui/actions/runs/23841810400/job/69500558649?pr=888#step:10:2403 |
fixes #869
markdown link labels weren't clickable because treesitter reports
concealedhighlights instead ofmarkup.linkfor symbols around the url and label ([...](...)). thedetectLinks()fn wasn't taking that into account.