fix(native): dont rely on colorterm for hyperlinks#879
Open
AnatoleLucet wants to merge 1 commit intoanomalyco:mainfrom
Open
fix(native): dont rely on colorterm for hyperlinks#879AnatoleLucet wants to merge 1 commit intoanomalyco:mainfrom
AnatoleLucet wants to merge 1 commit intoanomalyco:mainfrom
Conversation
AnatoleLucet
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminal capability detection assumed that if
COLORTERM=was set to eithertruecoloror24bit, hyperlinks should be supported.it can wrongly detect hyperlinks capability under some environments (e.g. over ssh where env vars are populated from the remote and not the host), so i removed it and completed the list of known terminal names that support OSC8.