fix(native): terminal not updated on new capabilities#877
Open
AnatoleLucet wants to merge 2 commits intoanomalyco:mainfrom
Open
fix(native): terminal not updated on new capabilities#877AnatoleLucet wants to merge 2 commits intoanomalyco:mainfrom
AnatoleLucet wants to merge 2 commits intoanomalyco:mainfrom
Conversation
0f0afe0 to
74da178
Compare
74da178 to
244d274
Compare
Author
|
made a little update to the pr because i realized my previous fix in the zig renderer could produce half-baked renders if stdin is processed mid-draw. demo of the issue with my hold fixscreenrecording-2026-03-27_11-29-39.mp4this is now fixed. i moved the "re-render when receiving capabilities" logic to typescript so it can be properly scheduled with the rest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering right after creating the renderer, features that depend on special capabilities (e.g. hyperlinks) won't work right away because the capability response has not been processes/received yet.
It results in a terminal output were some features won't work until their cells are updated.
For instance:
If we render a simple link right after creating the renderer (on a terminal that supports OSC8), the link won't work until these cells are re-rendered by the renderer, because the initial render did not send the OSC8.
To fix it, i added a forced render after processing new capabilities to make sure every feature works correctly with the latest capabilities.