fix(tui): center dialog properly and prevent overflow #7944
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
zerone0x
force-pushed
the
fix/dialog-overflow-centering-7902
branch
from
096479f to
b6c60e8
Compare
Use justifyContent="center" instead of fixed paddingTop for true vertical centering. Add maxHeight to prevent dialog from overflowing when terminal is small. Fixes anomalyco#7902 Co-Authored-By: Claude Opus 4.5 <[email protected]>
zerone0x
force-pushed
the
fix/dialog-overflow-centering-7902
branch
from
b6c60e8 to
5b40f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
justifyContent="center"instead of fixedpaddingTopfor true vertical centeringmaxHeightconstraint to prevent dialog from overflowing when terminal is smallFixes #7902