fix(plugin): show config unchanged message when install is a no-op#22485
Open
bensantora wants to merge 2 commits intoanomalyco:devfrom
Open
fix(plugin): show config unchanged message when install is a no-op#22485bensantora wants to merge 2 commits intoanomalyco:devfrom
bensantora wants to merge 2 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Seems like a good-enough solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22452
Type of change
What does this PR do?
If I understood the issue correctly - if / when a plugin is already configured and you run plugin install without the flag ' --force' , the install process runs but nothing in the config actually changes. The code before fixing would always print "Installed" regardless. This fix will perform a check to see whether a config item was actually modified (i.e. mode is not no-op) and prints "Config unchanged (use --force to replace)" if nothing was changed.
How did you verify your code works?
I reviewed the code and applied the fix as described in the issue - works for me.
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.