fix: add missing numpy import to logistic_regr.py#15
Closed
Mukller wants to merge 1 commit into
Closed
Conversation
logistic_regr.predict() calls np.ones() when all training labels are identical (self.flag is True), but numpy was never imported. This causes a NameError at runtime: NameError: name 'np' is not defined Added 'import numpy as np' at the top of the file. Fixes #13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
logistic_regr.predict()callsnp.ones()when all training labels are identical (self.flag is True), butnumpywas never imported at the top of the file. This causes aNameErrorat runtime:Fix
Added
import numpy as npat the top of the file alongside the existing import.Fixes #13