Skip to content

registration problem fixed#72

Open
VenomFate-619 wants to merge 5 commits intoanitab-org:masterfrom
VenomFate-619:master
Open

registration problem fixed#72
VenomFate-619 wants to merge 5 commits intoanitab-org:masterfrom
VenomFate-619:master

Conversation

@VenomFate-619
Copy link

Description

A changed was required in the property name of post data.

Fixes #71

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually

  • Go to the register page
  • Fill in the info
  • Submit the register form
  • You are redirected to login screen

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@VenomFate-619
Copy link
Author

@isabelcosta
There are some issues in QA Checks / Linters and Formatters

@VenomFate-619
Copy link
Author

@isabelcosta any update on the linter problem

@vj-codes
Copy link
Member

vj-codes commented Oct 4, 2021

@VenomFate-619 hey please run Prettier ( code linter ) locally and push the changes, then the check will pass! Do update if you have any more questions:)

@vj-codes vj-codes added the Status: Changes Requested Changes are required to be done by the PR author. label Oct 4, 2021
@vj-codes
Copy link
Member

vj-codes commented Oct 5, 2021

@isabelcosta please approve the workflow run

@vj-codes vj-codes added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Oct 5, 2021
@VenomFate-619
Copy link
Author

Is this project dead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Needs Review PR needs an additional review or a maintainer's review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: terms & conditions checkbox is checked but also the error is prompting

2 participants