test: logged in user gets redirected to Home with username on main Navigation bar

[rkraeher]

Description

• Fixes Test: Write test successful login user gets redirected to Homepage with username on main navbar #33

• Adds a test to check that the Login component will redirect to Home after a successful login (or when directly accessing the /login route).

• The issue also requires a test to check that the logged in user's username is displayed on the Navigation bar after being redirected to Home. As this is really checking Navigation component functionality, not Login, I have added a separate test file for Navigation

• The Login test requires an import of the history dependency

Type of Change:

• Quality Assurance

How Has This Been Tested?

• npm run test

Checklist:

• My PR follows the style guidelines of this project
• I have performed a self-review of my own code or materials
• I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged

Code/Quality Assurance Only

• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been published in downstream modules

[welcome]

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

[rkraeher]

Merge Conflict

Currently there is a merge conflict between this PR branch and development. The merge stems from two conflicting uses of Router from 'react-router-dom'.

Description

development uses an import alias for BrowserRouter. Right now I have simply added an alias for the Router object (calling it Redirect), as my test is the only one that needs it. BrowserRouter object will not work for the new test from this PR because the test mocks history.replace function that is used by the real Redirect component in the implementation of Login. But BrowserRouter does not accept the history prop, so I must use Router, not BrowserRouter for the redirect test. See docs

Possible Solution

This seems like a confusing and misleading alias usage, since in the test we use aliases, but both of those aliases are overriding the default export names of different package objects. I think a better solution would be to remove the BrowserRouter as Router alias and just import both BrowserRouter and Router from the package with their default export names.