Added a new settings section to hide buttons in player and crash fixes#1369
Closed
saieshshirodkar wants to merge 2 commits intoanilbeesetti:mainfrom
Closed
Added a new settings section to hide buttons in player and crash fixes#1369saieshshirodkar wants to merge 2 commits intoanilbeesetti:mainfrom
saieshshirodkar wants to merge 2 commits intoanilbeesetti:mainfrom
Conversation
added 2 commits
July 18, 2025 23:37
This commit introduces a new feature that allows users to customize the visibility of player control buttons. - Adds a new 'Buttons' section in the player settings. - Provides individual toggles to show or hide the Lock, Video Zoom, Picture-in-Picture, Background Play, and Screen Rotation buttons. - The player layout dynamically adjusts to hide empty space when all bottom-left buttons are disabled.
This commit fixes a bug where the app would crash if the storage permission was revoked while the media synchronizer was running. - The `LocalMediaSynchronizer` is updated to properly stop and restart. - The `MainActivity` now manages the synchronizer's lifecycle based on the permission status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new "Buttons" section in the player settings so you can customize which control buttons show up in the player UI.
What you can do now:
Toggle individual buttons:
Bottom-left: Lock, Zoom, Picture-in-Picture (PiP), and Background Play.
Top-right: Screen Rotation toggle.
Adaptive layout:
If you hide all the bottom-left buttons, the layout adjusts automatically — the progress bar and time indicators shift down to keep everything looking neat and clean.
I fixed a crash that happened when storage permission was revoked after being granted.
The issue:
The media sync process didn’t know how to handle the permission being taken away mid-session, and that caused the app to crash.
Also, once the sync was stopped (like after a permission change), it couldn’t restart properly.
The fix:
I made the synchronizer more robust so it can stop and restart cleanly.
The main screen now checks permission status properly — it starts syncing only when permission is granted and stops immediately when it’s not. No more crashes.
Overall, the app should now handle permission changes smoothly and stay stable no matter what.