build: experiment with windows testing#29637
Closed
devversion wants to merge 7 commits intoangular:mainfrom
Closed
build: experiment with windows testing#29637devversion wants to merge 7 commits intoangular:mainfrom
devversion wants to merge 7 commits intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
experiment-windows
branch
29 times, most recently
from
3f1fcf5 to
9eaaafa
Compare
devversion
force-pushed
the
experiment-windows
branch
21 times, most recently
from
1ba95c8 to
0085f66
Compare
tests/legacy-cli/e2e.bzl
Outdated
| toolchains = toolchains + ["@npm//@angular/build-tooling/bazel/browsers/chromium:toolchain_alias"] | ||
| data = data + ["@npm//@angular/build-tooling/bazel/browsers/chromium"] | ||
|
|
||
| windows_node_repo = kwargs.pop("windows_node_repo", None) |
Member
There was a problem hiding this comment.
How does all of this work below if windows_node_repo is actually None?
For instance "@//:node_files" is invalid right?
tests/legacy-cli/e2e.bzl
Outdated
| data = select({ | ||
| "@bazel_tools//src/conditions:windows": data + windows_node_files, | ||
| "//conditions:default": data + windows_node_files, | ||
| #"//conditions:default": data, |
Member
There was a problem hiding this comment.
Suggested change
| #"//conditions:default": data, |
…ble variant When testing native Windows via WSL, the loopback address (localhost) is not necessarily the correct one anymore. NOTE: This is not needed for general development/testing inside WSL; it's just needed because we still want to test native Windows on CI, and launch powershell/cmd from inside WSL to simulate a real native Windows CLI user experience. Context on why this is needed: When spawning e.g. ng serve via CMD, the process runs outside WSL, so `localhost`, when a test wants to assert the served content, is not correct. Instead the NAT IP of the Windows host needs to be used directly. This is what this change enables. Notably WSL does have a mirrored networking mode, but it doesn't work well. Requests from WSL to the Windows host typically fail with connection refused errors (and there are many issues reported). The NAT approach (default by WSL) is safer, and works, but is a little more work as can be seen in this commit.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information