fix: correct always-true condition in renderNestedTag#115
Closed
andrerfneves wants to merge 1 commit into
Closed
Conversation
The condition is always true because a value cannot be both a string and a number simultaneously. This caused strings to be rendered as objects (via Object.keys), producing individual character keys and duplicate rendering. Replace the tautological OR with a proper AND chain so the object branch only renders when tag.data is genuinely an object.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Closing as obsolete after the shadcn/Tailwind migration was merged. This PR targets src/app.jsx, which no longer exists on main; the nested result rendering code was replaced by the new InvoiceDetails component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The condition in the method was a tautology: is always true because a value cannot be both a string and a number simultaneously.
This caused the 'Objects' rendering branch to execute for strings, treating them as objects via , which produced individual character keys and duplicate rendering alongside the correct string branch.
Changes
Test Plan