fix: correct switch target in renderLNURLDetails for tag labels#114
Closed
andrerfneves wants to merge 1 commit into
Closed
fix: correct switch target in renderLNURLDetails for tag labels#114andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
The switch statement was comparing (always 'tag' since LNURL_TAG_KEY is 'tag') instead of (the actual tag value from decodedInvoice). This meant the payRequest/withdrawRequest labels were never applied. Change to so the tag label mapping works correctly for LNURL pay and withdraw requests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Closing as obsolete after the shadcn/Tailwind migration was merged. This PR targets src/app.jsx, which no longer exists on main; the results rendering was replaced by the new React/TSX component structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The statement in was comparing (always since is ) instead of (the actual tag value from ). This meant the / label mappings were never applied.
Changes
Test Plan