update phpstan to 2.0 and fix errors it reports#11
Open
tacman wants to merge 1 commit intoandanteproject:mainfrom
Open
update phpstan to 2.0 and fix errors it reports#11tacman wants to merge 1 commit intoandanteproject:mainfrom
tacman wants to merge 1 commit intoandanteproject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated PHPStan from 1.x to 2.0 and resolved all resulting analysis errors.
Tests pass.
Composer Updates
phpstan/phpstan:^1.2→^2.0phpstan/phpstan-phpunit:^1.0→^2.0phpstan/phpstan-symfony:^1.0→^2.0phpstan/extension-installer: kept at^1.4(not yet available as 2.0)Config Changes
phpstan.neon:checkMissingIterableValueTypecheckGenericClassInNonGenericObjectTypeproperty.onlyReadin test fixtures (Doctrine-managed entity IDs)Code Fixes
Source code:
TimestampableCacheClearer: Removed nullable type from property (never assigned null)Configuration: Added PHPDoc type hints for array parameters/return typesEntityConfiguration: Added PHPDoc type hint for array parameterTimestampableEventSubscriber: Fixed generic type annotationTest code:
Address,Organization: Changed?inttoint, added@readonlyPHPDocFunctionalTestCase: Fixedmethod_exists()call, usedlist<>typeMappingTest: Fixed generic type annotationcreateKernel(): Added@param array<string, mixed> $optionsPHPDoc