fix: key typeface caches by EntityId for Unity 6.3 - #96
Open
Rikarin wants to merge 3 commits into
Open
Conversation
Unity 6.3 (6000.5) marks Object.GetInstanceID() as [Obsolete(error: true)], so it raises CS0619 rather than a suppressible warning. Switching the call to GetEntityId() alone is not enough: the implicit EntityId -> int conversion is obsolete-as-error too, and is slated for removal, so assigning the result to an int just moves the error. Type the typeface cache keys as EntityId end to end instead. EntityId implements IEquatable<EntityId> and overrides GetHashCode, so it is a valid dictionary key, and == / != are defined on it. Also drops the #pragma warning disable CS0618 added in 53ad54b — it targeted the wrong diagnostic id and cannot suppress an error anyway. Verified with 6000.5.7f1's Roslyn against its UnityEngine assemblies: SkiaSharp.Unity compiles with 0 errors and no new warnings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: key typeface caches by EntityId for Unity 6.3
Unity 6.3 (6000.5) marks Object.GetInstanceID() as [Obsolete(error: true)],
so it raises CS0619 rather than a suppressible warning. Switching the call
to GetEntityId() alone is not enough: the implicit EntityId -> int
conversion is obsolete-as-error too, and is slated for removal, so
assigning the result to an int just moves the error.