Bug fix: allow user to pass dmesg.log for analysis #97
+178
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandraBara
requested review from
jaspals3123 and
landrews-amd
as code owners
landrews-amd
requested changes
Jan 7, 2026
test/functional/test_run_plugins.py
Outdated
Comment on lines
124
to
157
| collect_log_path = str(tmp_path / "collect_logs") | ||
| result = run_cli_command( | ||
| ["--log-path", collect_log_path, "run-plugins", "DmesgPlugin"], check=False | ||
| ) | ||
|
|
||
| output = result.stdout + result.stderr | ||
| assert result.returncode in [0, 1, 2] | ||
|
|
||
| dmesg_data_file = None | ||
| collect_path = Path(collect_log_path) | ||
|
|
||
| for log_dir in collect_path.glob("*"): | ||
| dmesg_plugin_dir = log_dir / "dmesg_plugin" / "dmesg_collector" | ||
| if dmesg_plugin_dir.exists(): | ||
| for dmesg_file in dmesg_plugin_dir.glob("dmesg*.log"): | ||
| dmesg_data_file = str(dmesg_file) | ||
| break | ||
|
|
||
| if not dmesg_data_file: | ||
| sample_dmesg_dir = tmp_path / "sample_data" | ||
| sample_dmesg_dir.mkdir(parents=True, exist_ok=True) | ||
| dmesg_data_file = str(sample_dmesg_dir / "dmesg.log") | ||
|
|
||
| sample_content = """[ 0.000000] Linux version 5.15.0-generic (buildd@lcy02-amd64-001) | ||
| [ 0.001000] Command line: BOOT_IMAGE=/boot/vmlinuz root=UUID=test ro quiet splash | ||
| [ 1.234567] pci 0000:00:01.0: BAR 0: failed to assign [mem size 0x01000000] | ||
| [ 2.345678] WARNING: CPU: 0 PID: 1 at drivers/test/test.c:123 test_function+0x123/0x456 | ||
| [ 3.456789] AMD-Vi: Event logged [IO_PAGE_FAULT device=00:14.0 domain=0x0000] | ||
| [ 4.567890] normal system message | ||
| [ 5.678901] ACPI Error: Method parse/execution failed | ||
| [ 10.123456] System is operational | ||
| """ | ||
| with open(dmesg_data_file, "w", encoding="utf-8") as f: | ||
| f.write(sample_content) |
Collaborator
There was a problem hiding this comment.
For a sample dmesg file we should just create a file in the fixtures directory. It should also have iso timestamps like this:
test/functional/test_run_plugins.py
Outdated
| ) | ||
|
|
||
| output = result.stdout + result.stderr | ||
| assert result.returncode in [0, 1, 2], f"Unexpected return code: {result.returncode}" |
Collaborator
There was a problem hiding this comment.
Why are we checking for all these different return codes? The return code should be 1 if it was able to run.
Collaborator
Author
There was a problem hiding this comment.
any of those indicates that it ran somehow, but yeah i can restrict it to 1.
Collaborator
There was a problem hiding this comment.
Sorry 0, if it ran successfully it should be 0
landrews-amd
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to run:
This will analyze the dmesg.log specified by user and disable a new collection.