test(plugins/cgroups/oar): Updates to add 80% test code coverage for CGroups/oar plugin#388
Open
victoryeagle77 wants to merge 1 commit intoalumet-dev:mainfrom
Open
test(plugins/cgroups/oar): Updates to add 80% test code coverage for CGroups/oar plugin#388victoryeagle77 wants to merge 1 commit intoalumet-dev:mainfrom
victoryeagle77 wants to merge 1 commit intoalumet-dev:mainfrom
Conversation
victoryeagle77
force-pushed
the
plugins/cgroups/oar
branch
from
db2bca0 to
33f95d8
Compare
victoryeagle77
force-pushed
the
plugins/cgroups/oar
branch
4 times, most recently
from
4735ebf to
9bfec08
Compare
TheElectronWill
requested changes
Apr 21, 2026
Member
TheElectronWill
left a comment
TheElectronWill
left a comment
There was a problem hiding this comment.
This is not the right approach to the problem.
util_cgroups::Cgroup exists for a good reason, and we want to keep it.
To create mock cgroups in your tests, use CgroupHierarchy::manually_unchecked.
See plugins/cgroups/util-cgroups/tests/cgroupv1.rs
victoryeagle77
force-pushed
the
plugins/cgroups/oar
branch
3 times, most recently
from
dab7f2a to
572d488
Compare
victoryeagle77
force-pushed
the
plugins/cgroups/oar
branch
4 times, most recently
from
e148f91 to
b85e74d
Compare
…CGroups/oar plugin
victoryeagle77
force-pushed
the
plugins/cgroups/oar
branch
from
b85e74d to
8a09da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.