PP-1233 spike how we can apply our own 3ds on stripe#5796
Draft
AbdirizakIdris wants to merge 1 commit intomasterfrom
Draft
PP-1233 spike how we can apply our own 3ds on stripe#5796AbdirizakIdris wants to merge 1 commit intomasterfrom
AbdirizakIdris wants to merge 1 commit intomasterfrom
Conversation
-This PR is to Look into if/how we could request 3DS for Stripe at a service level - Add new column for `forced_3ds` - Add `"payment_method_options[card][request_three_d_secure]"=any` param to Strupe Payment intent
AbdirizakIdris
force-pushed
the
PP-1233-spike-how-we-can-apply-our-own-3ds-on-stripe
branch
from
09ae681 to
3b61fb4
Compare
alexbishop1
requested changes
May 7, 2025
Contributor
alexbishop1
left a comment
alexbishop1
left a comment
There was a problem hiding this comment.
One small logic thing but otherwise this looks straightforward enough
| this.customerId = customerId; | ||
| this.offSession = offSession; | ||
| this.tokenId = tokenId; | ||
| this.required3ds = gatewayAccount.isForce3ds() || gatewayAccount.isRequires3ds(); |
Contributor
There was a problem hiding this comment.
I think this should be a && rather than a || — isRequires3ds() (not the best name any more) is whether the gateway account supports 3DS at all, which is a prerequisite for isForce3ds() to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR is to Look into if/how we could request 3DS for Stripe at a service level
force_3ds"payment_method_options[card][request_three_d_secure]"=anyparam to Stripe Payment intent