Merged
Conversation
storopoli
reviewed
Mar 26, 2026
Member
storopoli
left a comment
storopoli
left a comment
There was a problem hiding this comment.
Just one comment (not a blocker).
Comment on lines
-18
to
+21
| ### Sibling hashes required for proof. | ||
| inner: RawMerkleProofB32 | ||
| ### Index of the element for which this proof is for. | ||
| index: uint64 | ||
| ### Sibling hashes required for proof. | ||
| inner: RawMerkleProofB32 |
Member
There was a problem hiding this comment.
This diff is not needed right. This is a noop.
Member
There was a problem hiding this comment.
Actually not a noop. This fundamentally changes SSZ serialization order why?
Collaborator
Author
There was a problem hiding this comment.
it should have been like this in the first place 😭
delbonis
force-pushed
the
feature/mmr-batch-init
branch
from
a6d756b to
3ed816a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does three things:
CompactMmr64only available if the newlegacy_compactfeature is enabled, we should only be using the SSZ version everywhere now, doing some reorganization in the processnew_repeatedfn to create efficiently create MMR instances containing lots of repeated elements, with an exhaustive testType of Change
Notes to Reviewers
Checklist
Related Issues