Conversation
|
Thank you for this hard and useful work @canyon289 and @aloctavodia ! |
|
Hey @AlexAndorra would you be open to reviewing as I finish the exercises? Notebooks are hard to work on in parallel but an extra set of eyes would be helpful! |
|
Sure, would be happy to! |
|
Any of the ones in PR really. Just a heads up though. Osvaldo and I are reeeaaalllllyyyy slow on this. Like we've taken months, and sometimes take multiple weeks to respond to each other. If were slow with you too please don't be frustrated :) |
|
Ha ha I totally understand! I'm doing that on my spare time too, which is quite cyclical (but, sadly, rather hard to predict, even with a Bayesian model...). |
|
No worries. Thank you for your time. We really appreciate your efforts :) |
|
Going through the exercises, a first thought is that it would be useful for readers to have the text of the questions, that are in the book, in addition to the answers. |
|
If @aloctavodia agrees I can add them into the ones in review to make things easier |
|
That would be great! |
|
Happy to see you both working together, I agree with both of you! :-) |
|
Ha ha good to have you back Osvaldo (and also good luck 😉)!
I'll do the PR and reviews ASAP then!
FYI, I'm doing the transition in the opposite direction 😜
Le ven. 26 juil. 2019 à 21:53, Osvaldo Martin <[email protected]> a
écrit :
… Happy to see you both working together, I agree with both of you! :-)
I am slowly transitioning from vacation to going back to work :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40?email_source=notifications&email_token=AHIJMTBRNVR2DZ3EE2CTL6LQBNI3DA5CNFSM4IFZWHQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25RYVQ#issuecomment-515578966>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHIJMTBLKJVKX4RKAD4ZMOTQBNI3DANCNFSM4IFZWHQQ>
.
|
|
So either @aloctavodia or @AlexAndorra I could use help! On this section for question 4 to 6 I'm getting a ton of divergences and not really sure what to do about it. Tried increasing tuning and number of samples but no luck :( |
|
Thank you Ravin! I'll try to take a look this week or the next ;) |
|
@aloctavodia do you think you could set up the Review NB App on this repo? I think it would make the review process easier ;) Thank you! |
|
So I managed to take a look at your NB @canyon289 🎉 Here are my (deep) thoughts (sorry it's not very convenient, but without the Review NB app I don't see any other way):
|
|
@AlexAndorra Thanks for the feedback here and on ch7 For question 2: I'm using the ArviZ version in the For Exercise 6. I'm actually not sure. I thought the way I specified the model is how MultiObserved works in ArviZ. I'll ask on the PyMC discourse to be sure. As for the rest I appreciate you going through them! I'll implement your suggestions this weekend. PyMCheers! |
|
You're welcome Ravin ;) FYI, I'm using Arivz's latest version (0.4.1), which means a novelty broke this specific code... Do I need to open an issue on Arivz's repo? For exercise 6, my knowledge stops there on the matter, but I'm curious about the answer. I'll follow your question on Discourse! |
|
Fixed exercise 2 per Alex's notes. Thank you! |
No description provided.