feat(location): add back function capability in the location #520
Open
vctrths wants to merge 4 commits into
Open
feat(location): add back function capability in the location #520vctrths wants to merge 4 commits into
vctrths wants to merge 4 commits into
Conversation
commit: |
benmerckx
reviewed
Jun 26, 2026
Comment on lines
+685
to
+737
| function useResolvedEntryPickerLocation( | ||
| options: Partial<EntryPickerOptions>, | ||
| fallbackLocation: EditorLocation | undefined | ||
| ): EditorLocation | undefined { | ||
| const graph = useGraph() | ||
| const entry = useEntry() | ||
| const [location, setLocation] = useState(() => | ||
| typeof options.location === 'function' | ||
| ? fallbackLocation | ||
| : (options.location ?? fallbackLocation) | ||
| ) | ||
|
|
||
| useEffect(() => { | ||
| if (typeof options.location !== 'function') { | ||
| setLocation(options.location ?? fallbackLocation) | ||
| return | ||
| } | ||
|
|
||
| if (!entry) { | ||
| setLocation(fallbackLocation) | ||
| return | ||
| } | ||
|
|
||
| let cancelled = false | ||
| const info: EditorInfo = {graph, entry} | ||
| Promise.resolve(options.location(info)) | ||
| .then(location => { | ||
| if (!cancelled) setLocation(location ?? fallbackLocation) | ||
| }) | ||
| .catch(error => { | ||
| console.error('Failed to resolve entry picker location', error) | ||
| if (!cancelled) setLocation(fallbackLocation) | ||
| }) | ||
|
|
||
| return () => { | ||
| cancelled = true | ||
| } | ||
| }, [ | ||
| entry?.id, | ||
| entry?.locale, | ||
| entry?.parentId, | ||
| entry?.root, | ||
| entry?.type, | ||
| entry?.workspace, | ||
| fallbackLocation?.parentId, | ||
| fallbackLocation?.root, | ||
| fallbackLocation?.workspace, | ||
| graph, | ||
| options.location | ||
| ]) | ||
|
|
||
| return location | ||
| } |
Member
There was a problem hiding this comment.
This looks like it should be an atom not an effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.