rotate: add an optional random rotation feature in INT8/INT4 quantization method#483
Merged
Conversation
zzlin237
requested review from
Cuiyus,
JalinWang,
chinaux,
feihongxu0824,
richyreachy and
zhourrr
as code owners
June 9, 2026 13:11
Collaborator
|
…class with FhtRotator/MatrixRotator inheritance
…class with FhtRotator/MatrixRotator inheritance
JalinWang
reviewed
Jun 24, 2026
JalinWang
reviewed
Jun 24, 2026
JalinWang
reviewed
Jun 24, 2026
JalinWang
reviewed
Jun 24, 2026
JalinWang
reviewed
Jun 24, 2026
JalinWang
reviewed
Jun 24, 2026
richyreachy
reviewed
Jun 25, 2026
egolearner
reviewed
Jun 26, 2026
egolearner
reviewed
Jun 26, 2026
egolearner
reviewed
Jun 26, 2026
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
JalinWang
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Feature: Added an optional rotation parameter to INT8 quantization, now supporting HNSW, Flat, IVF, and Vamana indexes.
Background: The quantization error in INT8 is directly proportional to the data range (max - min). By applying a random rotation, we can distribute the variance evenly across all vector dimensions. This helps reduce the overall range in certain cases, thereby improving INT8 quantization accuracy.
Benefits: Recall is improved while maintaining the same QPS. Using the cohere-1m dataset as an example:
Known Issues: We encountered issues during IVF testing and discovered pre-existing bugs in the IVF index:
The test results for INT4 are as follows: