refactor: extract duplicated rate-limiting code into factory functions#2893
Draft
refactor: extract duplicated rate-limiting code into factory functions#2893
Conversation
|
|
Co-authored-by: liuyib <[email protected]>
Co-authored-by: liuyib <[email protected]>
…ertions Co-authored-by: liuyib <[email protected]>
Co-authored-by: liuyib <[email protected]>
Copilot
AI
changed the title
[WIP] Refactor duplicated code for better maintainability
refactor: extract duplicated rate-limiting code into factory functions
Jan 9, 2026
commit: |
Collaborator
|
很好的提议,之前也有这个想法,等到 v4 再合 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[English Template / 英文模板]
🤔 这个变动的性质是?
💡 需求背景和解决方案
问题:useDebounceFn/useThrottleFn、useDebounce/useThrottle、useDebounceEffect/useThrottleEffect 存在 ~95% 代码重复(每对各约 46、20、26 行)。
方案:提取通用模式到三个工厂函数:
createRateLimitFn - 生成 useDebounceFn/useThrottleFn
createRateLimitValue - 生成 useDebounce/useThrottle
createRateLimitEffect - 生成 useDebounceEffect/useThrottleEffect
新增目录:
packages/hooks/src/createRateLimitHooks/结果:
📝 更新日志
☑️ 请求合并前的自查清单
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.