Skip to content

Allow appLaunchURL to have any scheme - #263

Merged
alexandercerutti merged 1 commit into
alexandercerutti:masterfrom
xpol:fix-262-appLaunchURL
Dec 25, 2025
Merged

Allow appLaunchURL to have any scheme#263
alexandercerutti merged 1 commit into
alexandercerutti:masterfrom
xpol:fix-262-appLaunchURL

Conversation

@xpol

@xpol xpol commented Dec 24, 2025

Copy link
Copy Markdown
Contributor

Description

Fix #262 by change the validation schema from http(s) regex to Joi.string().uri().

Check relevant checkboxes

  • I've run tests (through npm test) and they passed
  • I generated a working Apple Wallet Pass after the change
  • Provided examples keep working after the change
  • This improvement is or might be a breaking change

Relevant information

@alexandercerutti alexandercerutti left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Will merge soon, thank you for your contribution!

@alexandercerutti
alexandercerutti merged commit 87239a7 into alexandercerutti:master Dec 25, 2025
1 of 2 checks passed
@alexandercerutti

Copy link
Copy Markdown
Owner

Released in v3.5.7 🎉 Thank you for your contribution!
If you could leave a 🌟 to the project, it would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The appLaunchURL do not have to be a http(s) protocol

2 participants