refactor(create-electron): Changed names for electron main and preload files#31
Open
NaspoDev wants to merge 2 commits intoalex8088:masterfrom
Open
refactor(create-electron): Changed names for electron main and preload files#31NaspoDev wants to merge 2 commits intoalex8088:masterfrom
NaspoDev wants to merge 2 commits intoalex8088:masterfrom
Conversation
main process file changed from index.js/ts to main.js/ts | preload files from index.js/ts to preload.js/ts. (including .d.ts files). The webPreferences preload config was also update to reflect this new name change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I find that the project structure of electron apps would be a lot more clear if the main process file is named main.js, and the preload file named preload.js. Currently, they are both named index.js, which is a bit confusing/unorganized.
This pull request has, for all frameworks:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).