feat(cloudflare/ruleset): add Ruleset resource#240
Open
agcty wants to merge 2 commits intoalchemy-run:mainfrom
Open
feat(cloudflare/ruleset): add Ruleset resource#240agcty wants to merge 2 commits intoalchemy-run:mainfrom
agcty wants to merge 2 commits intoalchemy-run:mainfrom
Conversation
Author
|
Verification update:
|
Author
|
Marking this ready for review now. One dependency remains for full live-test verification: alchemy-run/distilled#257 needs to land or be otherwise consumed by this repo so the generated Rulesets client uses the correct phase-entrypoint path. The current implementation and focused tests are ready for review, and the live-test blocker is documented above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a first-class Cloudflare Ruleset resource for zone phase entrypoints.
rulesets.putPhas{ zoneId }, zone ID strings, and hostname strings for zone selectionCLOUDFLARE_TEST_RULESET_ZONE_IDDepends on alchemy-run/distilled#257 for generated Rulesets phase path support.
Verification run:
bun vitest run packages/alchemy/test/Cloudflare/Ruleset/Ruleset.test.tsbun tsc -b --pretty falsegit diff --check