Skip to content

Update seo-audit.mjs - #826

Closed
unoukujou wants to merge 1 commit into
alam00000:mainfrom
unoukujou:main
Closed

Update seo-audit.mjs#826
unoukujou wants to merge 1 commit into
alam00000:mainfrom
unoukujou:main

Conversation

@unoukujou

@unoukujou unoukujou commented Aug 8, 2026

Copy link
Copy Markdown

Fix #820

Summary by CodeRabbit

  • Bug Fixes
    • Improved canonical URL generation for sites configured with a base path.
    • Ensured trailing slashes are handled consistently in configured base URLs.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Required

Thank you for your contribution! Before we can accept your pull request, you need to sign our Contributor License Agreement (CLA).

Why do we need a CLA?

BentoPDF uses a dual licensing model (AGPL-3.0 for open source + commercial license). The CLA allows us to:

  • Include your contributions in both open source and commercial versions
  • Protect you and us legally
  • Keep the project sustainable

How to sign

To sign the CLA, please comment on this PR with:

I have read the CLA Document and I hereby sign the CLA

For corporate contributions, please have your organization sign our Corporate CLA (CCLA) by contacting us at contact@bentopdf.com.


⚠️ Note: You only need to sign the CLA once. Future contributions to this repository will not require re-signing.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 10b8f184-8ae7-42df-a2da-3c565aacbfd8

📥 Commits

Reviewing files that changed from the base of the PR and between 2ed0575 and ef66d19.

📒 Files selected for processing (1)
  • scripts/seo-audit.mjs

📝 Walkthrough

Walkthrough

The SEO audit now derives a normalized BASE_PATH from BASE_URL and includes it when generating expected canonical URLs.

Changes

SEO canonical audit

Layer / File(s) Summary
Normalize and apply the base path
scripts/seo-audit.mjs
The script derives BASE_PATH from BASE_URL and adds it to expected canonical URLs before the page slug.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only “Fix #820” and omits the required summary, change type, testing details, results, dependencies, and checklist. Add the change summary, motivation, dependencies, selected change type, reproducible tests with expected and actual results, and completed checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the changed file and relates to the fix, but it does not state that BASE_URL is included in canonical URL validation.
Linked Issues check ✅ Passed The change adds BASE_URL-derived base-path handling to canonical URL expectations, addressing subpath deployments and the mismatches described in issue #820.
Out of Scope Changes check ✅ Passed The two-line change is limited to seo-audit.mjs and directly supports the BASE_URL canonical URL fix in issue #820.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@unoukujou
unoukujou marked this pull request as draft August 8, 2026 11:33
@unoukujou unoukujou closed this Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Bug) seo-audit.mjs canonical check ignores BASE_URL

1 participant